fix(server): correct SSE Content-Type header (text/readystream → text/event-stream)#2128
Open
xb17 wants to merge 1 commit into
Open
fix(server): correct SSE Content-Type header (text/readystream → text/event-stream)#2128xb17 wants to merge 1 commit into
xb17 wants to merge 1 commit into
Conversation
…vent-stream text/readystream is not a valid MIME type. Strict SSE clients (browser EventSource, WebView2, some proxies) require the correct text/event-stream type to parse the stream. Also removes a hardcoded Access-Control-Allow-Origin header pointing to a specific dev port, which has no effect in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
/chatSSE endpoint setsContent-Type: text/readystream, which is not a valid MIME type.Why it matters
Strict SSE clients — including browser
EventSource, Tauri WebView2, and some reverse proxies — check theContent-Typeheader before parsing the stream. An invalid type causes them to treat the response as a plain HTTP body rather than an event stream, breaking streaming entirely for those clients.The correct MIME type for Server-Sent Events is
text/event-stream(per the WHATWG SSE spec).This also removes a hardcoded
Access-Control-Allow-Origin: http://localhost:5173header on the same handler, which has no effect in production and points to a specific dev-server port.Change
internal/server/chat.go— one-line fix to the Content-Type string, remove stale CORS header.